๐ Weโll start by checking the repository today. What are the most important issues?
๐ข Iโve merged PR#66. Letโs list the outstanding issues now.
65 OPEN Add Mermaid Support to Netlify Installation
64 OPEN Fix `xvc-storage` compilation warnings bug
54 OPEN Fix all references to `xvc data` in the documentation
51 OPEN Add a benchmark script to compare Xvc with other tools
50 OPEN Consider changing `xvc file push` to `xvc file send` and `xvc file pull` to `xvc file retrieve`
49 OPEN Add `--generic-command` as a dependency type to `xvc pipeline dependency`
48 OPEN Write rsync example for `xvc storage generic` documentation
47 OPEN Write rclone example for `xvc storage generic` documentation
46 OPEN Allow to skip init in remotes with `--skip-init` option
45 OPEN Update `VStore::to_store` to use some internal mechanism to avoid `XvcStore::insert`
43 OPEN Update to `clap 4.0`
42 OPEN Clean up xvc crate dependencies
36 OPEN Add version to released file binaries
33 OPEN Update `arch/remotes.md` for new naming documentation
32 OPEN Remove arc42 sections from the documentation documentation
29 OPEN Add documentation for `xvc storage new gcs` documentation
28 OPEN `xvc storage new yandex` enhancement
24 OPEN Create a logo for Xvc documentation
23 OPEN Add a Github action to upload new versions to crates.io automation
20 OPEN ref: Add rsync example for `xvc storage new generic`
18 OPEN Add a new workflow for remote tests automation
12 OPEN Create a website for Xvc
5 OPEN Add storage tests to Github Actions automation
4 OPEN fix clippy warnings bug
1 OPEN `xvc storage new` for all S3 compatible cloud services supported by `rust-s3`
๐ As far as I know, you removed the arc42 stubs from the docs yesterday. You can close issue #32.
๐ข I closed it via gh issue close.
๐ You should add a comment to that.
๐ข Added the comment.
๐ Itโs October 30th. Looking at the logs, youโve closed some more issues since we last talked.
๐ข Iโve been productive over the last few days. Now, letโs take a look at the open issues.
๐ I think you have a more pressing problem. Your tests are failing. You need to fix them first before moving to another task.
๐ข Created a new issue. The logs say:
81Z error: 7 targets failed:
2022-10-29T18:18:36.8969467Z ##[error] `-p xvc-workflow-tests --test test_storage_new_digital_ocean`
2022-10-29T18:18:36.8970697Z `-p xvc-workflow-tests --test test_storage_new_gcp`
2022-10-29T18:18:36.8971279Z `-p xvc-workflow-tests --test test_storage_new_generic_rsync`
2022-10-29T18:18:36.8971840Z `-p xvc-workflow-tests --test test_storage_new_minio`
2022-10-29T18:18:36.8972387Z `-p xvc-workflow-tests --test test_storage_new_r2`
2022-10-29T18:18:36.8973035Z `-p xvc-workflow-tests --test test_storage_new_s3`
2022-10-29T18:18:36.8973577Z `-p xvc-workflow-tests --test test_storage_new_wasabi`
2022-10-29T18:18:36.9368079Z ##[error]The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
๐ Looking at the logs, you should clean up those older branches.
๐ข Letโs do it now.
๐ข Done. Iโve deleted all branches except main.
๐ Good. I think the best way is to delete them as soon as you merge them.
๐ข Iโve activated that setting. These were older branches.
๐ Cool. Now, will you be checking the failing tests?
๐ข I think remote tests should never run if there are other errors. We can run coverage and remote tests as a second step after the first succeed.
๐ That seems like a neat idea. You want to split the current job into two: one for compiling and testing the non-remote parts, and the second for coverage and storage tests. It wonโt waste CI minutes that way?
๐ข On second thought, I think at the moment, thatโs not a pressing issue. We should start fixing these tests at once. We can split them later.
๐ Ok. It looks from the logs like secrets are not being made available to your jobs.
2022-10-29T18:18:17.5039311Z test test_storage_new_digital_ocean ... FAILED
2022-10-29T18:18:17.5039550Z
2022-10-29T18:18:17.5039652Z failures:
2022-10-29T18:18:17.5039784Z
2022-10-29T18:18:17.5040197Z ---- test_storage_new_digital_ocean stdout ----
2022-10-29T18:18:17.5040558Z Error: VarError { source: NotPresent }
2022-10-29T18:18:17.5040758Z
2022-10-29T18:18:17.5040765Z
๐ข I added them now. Letโs wait until the job ends to get a new set of logs.
๐ You can write some documentation in the meantime.
๐ข I think #82 is a good candidate for this. There must not be too many missing docs in the ECS crate.
๐ It was about walker and you fixed the ecs. Youโre the most absentminded developer here, I believe.
๐ข Ooops, youโre right. Iโll add them together in a single PR.
๐ In the meantime, the storage testing job has ended with ๐ด.
๐ข Checking the raw logs. It looks like we didnโt update the tests to match the current options:
2022-10-30T14:45:50.1058348Z error: Found argument '--storage-prefix' which wasn't expected, or isn't valid in this context
2022-10-30T14:45:50.1059809Z ##[error]Found argument '--storage-prefix' which wasn't expected, or isn't valid in this context
2022-10-30T14:45:50.1061740Z If you tried to supply `--storage-prefix` as a value rather than a flag, use `-- --storage-prefix`
2022-10-30T14:45:50.1063220Z
2022-10-30T14:45:50.1063394Z USAGE:
2022-10-30T14:45:50.1064302Z xvc storage new digital-ocean --name <NAME> --bucket-name <BUCKET_NAME> --region <REGION>
๐ Is it --storage-prefix or --remote-prefix? Which one is clearer?
๐ข I think updating the tests to conform to the current options is better for now. We can update the options later if desired.
๐ Another failure is rg. You assume it exists on the testing system.
๐ข ripgrep is available in Ubuntu 20.04, so we can just update the initial package list.
๐ The same --storage-prefix failure appears in the minio tests.
๐ข Ok. Fixing it.
๐ S3 tests want to run the new-s3 subcommand. I think we now see why we need these tests in the first place.
๐ข Yeah. Fixing the prefix option, too.
๐ s3cmd is also required. You should add it, too.
๐ข Ok. I think weโve added all missing dependencies. Iโll have to convert the mc tests for Minio to use s3cmd.
๐ Then we can try again. Now, we can get back to documentation.
๐ข Added some more documentation to PR#93. I think itโs better to return to the storage test errors now.
๐ It looks like you have missing DigitalOcean credentials.
๐ข Letโs take a look.
๐ข Iโve updated the tests to use a config file instead of command-line arguments that would be visible in the logs.
๐ Good practice. You also need to remove previous logs.
๐ข Maybe there is an option for that.
๐ It looks like there isnโt. There are masking options; when we add them to secrets, they are masked. But you shouldnโt use them in calls anyway.