🐢 The only failure was the patch coverage in Xvc. Let’s see what needs to be done.
🐇 It looks, from the coverage page, that our additions to HStore don’t have any tests. Maybe we can add some unit tests to the new joins.
🐢 I don’t find unit tests particularly useful, but let’s use GitHub Copilot to add some for us.
🐇 I added a unit test and a doc test for full_join. I think doc tests have more value; they provide documentation, and we can readily see how to use a function from its docs. It’s better to increase coverage with doc tests.
🐢 There are things I should keep in mind while writing doc tests. Imports must use the full path, not crate. Also, the tested struct doesn’t have implicit imports.
🐇 The ceremony for adding keys and values is a bit too much. It might be worthwhile to add an insert method for anything that implements Into<XvcEntity>.
🐢 That would certainly save time—no more typing .into() for each key! :)
🐇 Pushed to test again. Should we have some way to test coverage locally?
🐢 I don’t think we need to check coverage locally. It’s not worth our time right now.
🐇 Now, while waiting for the tests to complete, what else can we do?
gh -R iesahin/xvc run list
completed failure v0.6.13 Rust-CI v0.6.13 pull_request 12543831360 3m54s 2024-12-30T08:15:06Z
...
🐢 That didn’t take too long. Let’s view the results:
gh -R iesahin/xvc run view 12543831360
...
X Run Current Dev Tests
...
To see what failed, try:
View this run on GitHub: https://github.com/iesahin/xvc/actions/runs/12543831360
🐢 The current dev tests are failing for some reason. Let’s run them locally.
🐇 We’re missing llvm-tools-preview locally. How do I install this?
🐢 The command is rustup component add llvm-tools-preview:
info: component 'llvm-tools' for target 'aarch64-apple-darwin' is up to date
🐇 It’s already installed. We just need to set the environment variables.
🐢 Instead, we can just turn off dev tests for the time being. We don’t really need them; our local tests pass.
🐇 Yeah, okay. We don’t need to solve every single bit of these issues right now.
gh -R iesahin/xvc run list
...
🐇 Okay, let’s take a look at the run again.
gh -R iesahin/xvc run list
completed failure v0.6.13 Rust-CI v0.6.13 pull_request 12544020064 3m39s 2024-12-30T08:33:25Z
gh -R iesahin/xvc run view 12544020064
...
X Test and Coverage
...
gh run view 12544020064 --log-failed
...
Test and Coverage (stable) Test and Coverage 2024-12-30T08:36:58.8911690Z Error: ProcessError { stdout: "", stderr: " % Total % Received % Xferd Average Speed Time Time Time Current\n Dload Upload Total Spent Left Speed\n\r 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0\r 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0\ncurl: (7) Failed to connect to e1.xvc.dev port 80 after 160 ms: Couldn't connect to server\n" }
...
🐢 We need to start Nginx on the server. We forgot to do that yesterday.
🐇 Ah, right. After that dufs installation. Okay.
🐢 We also need to add a reverse proxy for dufs somehow, but that’s for later.
🐇 For this use case, I don’t think it’s necessary. We can just adjust the port to a non-standard one if we need 443 for something else. Let’s look at the tests again.
🐢 Let’s add another doc test, this time to XvcStore.
cargo test -p xvc-ecs --doc
...
test result: ok. 8 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 2.87s
🐇 Sent the files again. Waiting for the tests to finish.
🐢 Let’s check the keymaps file in the meantime.
🐇 I tried reading the documentation but didn’t see an error. Maybe we should just set it to non-lazy and disallow remaps.
🐢 We’ve already spent too much time on this.
🐇 Yes, let’s check the tests again.
gh -R iesahin/xvc run list
completed success v0.6.13 Rust-CI v0.6.13 pull_request 12544291068 8m10s 2024-12-30T09:00:42Z
...
🐢 Oh, nice, the merge is ready.
🐇 Patch coverage is still behind the target, though.
🐢 Yeah, but let’s release this one and ensure the next one is better covered. Also, I’m not sure if the doc tests actually affected the coverage report.
🐇 If we look at the coverage page again, we can see.
🐢 It seems codecov.io doesn’t consider coverage for doc tests. That’s a bit weird, but let’s not spend more time on it.
🐇 Sure, let’s merge.
🐢 I think we forgot to bump the versions in the Cargo.toml files. We’ll have to do that in main.
🐇 Oh, yeah. Let’s bump them and tag the release as well.
🐢 Now we can wait for all the files to be produced. What’s next?
🐇 We can release the Python version too. It shouldn’t need any changes.
🐢 Right. Maybe we can add a few tests there as well.
🐇 Let’s bump the version first and see.
🐢 I’ve bumped the versions in Cargo.toml and run maturin develop.
🐇 It seems ready now.
🐢 The main branch is failing, though. The “Publish crates” action is looking for libsqlite3. Let’s investigate.
gh -R iesahin/xvc run list
completed failure Release v0.6.13 Publish Crates v0.6.13 push 12544753359 6m1s 2024-12-30T09:41:56Z
🐢 The issue is that the VM doesn’t have libsqlite3-dev. Let’s add it.
🐇 We need to restart the job manually. Let’s skip tagging this time.
🐢 Some of the packages were already published, and now they’re causing failures because crates.io says they already exist. Maybe we can check if a package is already published before trying.
🐇 Let’s see if we can make cargo publish more forgiving.
🐢 There doesn’t seem to be an easy option. Let’s search for “how to skip published packages in workspace to avoid errors with cargo publish.”
🐇 Claude is hallucinating again. Let’s try a manual approach: how to skip already published packages?
🐢 It might be easier to just add a check. How do we get that info?
🐇 Or we can just move on to the next package if one is already available.
🐢 Let’s push the missing packages manually this time.
🐢 We should have a key to open garden files quickly. What does Fzf-Lua files receive as arguments?
🐇 Let’s check the help page: fzf-lua.
🐢 Before that, maybe we can try to fix why selected lines are not searched in Visual-Line mode?
🐇 Yep, let’s fix our search first.
🐢 How do you set a key in visual line mode in Neovim Lua?
🐇 The abbreviation is V. Let’s try that.
🐢 Looks like we need to restart the session.
🐇 It’s still not working. Let’s check :map.
🐢 It seems it needs more care; I’ll check it later.
👨🏾🦲 🐢 Bence kendini biraz daha anlamlı bir işle uğraştırmalısın. 🐇 Ne gibi? 🐢 Belki biraz daha yayın yapmalısın, biraz daha işe başvurmalısın. 🐇 “Meli”, “malı” ile geçiyor ömrümüz.
⌚ 🐢 It looks like we can move most of the daily template to links or commands. We can call it ref/daily. My idea is to fill the page intentionally, without templates.
🐇 It might be better to start with a blank page, yeah. The template makes me a bit nervous. There are too many things to fill in, and most of them aren’t things I like being pushed into doing.
🐢 Let’s start by moving the daily templates to ref/daily. No more daily template.
🐇 Now we can delete the rest of this page. We’ll use the daily links page and maybe have reminders at the end of these sessions.
👨🏽⚕️