Xvc Devlog
Iโll start a new series to record my Xvc development progress. I think itโs nice to have dialog between ๐ข and ๐ to explain the decisions and progress. These will be published in my personal blog for now. In the future, we can have a dedicated blog for this.
๐ LGTM. I think you can also link to commits here when they occur.
๐ข I think thatโs a bit too much work but PRโs may be linked.
๐ Ok. Letโs start with the PRs. What do you work on these days?
๐ข I started fixing warnings in https://github.com/iesahin/xvc/issues/3 and now fixing missing documentation warnings.
๐ Do you really think that weโll have a use for [RMNStore] in the future?
๐ข Iโm not sure. Possibly any M-N relationship can be tracked by two 1-N relationships. Under the hood this is what RMNStore does actually.
๐ Maybe we should just remove it.
๐ข I want to save it for the time being. If [xvc-ecs] will be used in other places, it may be needed.
๐ Ok. Probably YAGNI, but letโs keep it for the time being.
๐ข Writing documentation may be a debugging method too. I think Iโve found the reason for a bug here
๐ Umm, how could it lead to a bug?
๐ข Insert mean new event happened. But when converting a VStore to an XvcStore, new events are not happening. We are simply converting from one store to another.
๐ That means, they are added to XvcStore::current events, not XvcStore::previous , and when save_dir is called, they are saved.
๐ข Yeah, that was the bug. Time to time I was seeing duplicate JSON files.
๐ Then maybe itโs better to limit all insert usage.
๐ข Yeah, I should review that too.
๐ Added a bug report .
๐ข Iโm installing cargo-geiger to show that there is no unsafe code.
๐ Do you think youโll maintain Xvc that way? It wonโt require any unsafe code?
๐ข Maintain the forbidden(unsafe) status? I think so. Xvc doesnโt seem to need any unsafe blocks by itself. Most of the dependencies may need though.
๐ Working on it. and will be merged today.
๐ข I worked about that s3cmd bug yesterday and it turned out that my modification on the configuration was the cause.
๐ You were thinking that itโs about R2 all along?
๐ข I should suspect with my custom config more.
๐ Anyway, congratulations ๐ that Xvc now has Cloudflare R2 support.